[HOTFIX] Fix Blob Chemical #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ОбзорWalkthroughВ системе Changes
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Content.Server/Backmen/Blob/Systems/BlobTileSystem.cs (1)
172-182: Предложения по улучшению реализации леченияТекущая реализация работоспособна, но есть несколько моментов для улучшения:
- Магическое число
2.0fлучше вынести в константу уровня класса- Метод
TryAddможет пропустить обновление значения, если ключ уже существует- Отсутствует проверка
DamageDictна nullПредлагаю следующие изменения:
+ private const float RegenerativeMateriaModifier = 2.0f; private void HealTile(Entity<BlobTileComponent> ent, Entity<BlobCoreComponent> core) { var healCore = new DamageSpecifier(); var modifier = 1.0f; if (core.Comp.CurrentChem == BlobChemType.RegenerativeMateria) { - modifier = 2.0f; + modifier = RegenerativeMateriaModifier; } + if (ent.Comp.HealthOfPulse.DamageDict == null) + return; + foreach (var keyValuePair in ent.Comp.HealthOfPulse.DamageDict) { - healCore.DamageDict.TryAdd(keyValuePair.Key, keyValuePair.Value * modifier); + healCore.DamageDict[keyValuePair.Key] = keyValuePair.Value * modifier; } _damageableSystem.TryChangeDamage(ent, healCore); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Content.Server/Backmen/Blob/Systems/BlobTileSystem.cs(1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (1)
- GitHub Check: build (ubuntu-latest)
|
@KayzelW мёрдж пожалуста |
KayzelW
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Срочный хотфикс для Регенеративной Материи блоба
Summary by CodeRabbit